Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

vigyasharma commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2764418906 I think we can add a couple more tests to make it robust. 1. Some tests around concurrency – index with multiple threads, then advance the counter in one of the threads, and valid

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2766116736 Thanks, @vigyasharma I also looked at Lucene's native segment replication, just sharing my personal opinion. > Also, IIUC `IndexWriter#advanceSegmentInfosVersion()` was a

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2766081605 Thanks, @vigyasharma > I think we can add a couple more tests to make it robust. > > 1. Some tests around concurrency – index with multiple threads, then advance the cou

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

vigyasharma commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2764422079 Also, IIUC `IndexWriter#advanceSegmentInfosVersion()` was added to handle similar scenarios for NRT replication (Lucene's native segment replication implementation). I'm curious why

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on PR #14417: URL: https://github.com/apache/lucene/pull/14417#issuecomment-2757291661 Thanks for helping with the code review, I have made modifications according to the suggestions -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015957918 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ## @@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues() throws

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015958210 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ## @@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues() throws

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015954336 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long newVersion)

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015951779 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long newVersion)

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015872376 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ## @@ -5037,4 +5037,45 @@ public void testDocValuesSkippingIndexWithoutDocValues() throws

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

vigyasharma commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015832195 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ## @@ -5037,4 +5037,47 @@ public void testDocValuesSkippingIndexWithoutDocValues() throws Ex

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

vigyasharma commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015825615 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -1427,6 +1427,24 @@ public synchronized void advanceSegmentInfosVersion(long newVersion) {

Re: [PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

vigyasharma commented on code in PR #14417: URL: https://github.com/apache/lucene/pull/14417#discussion_r2015817265 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ## @@ -5037,4 +5037,45 @@ public void testDocValuesSkippingIndexWithoutDocValues() throws Ex

[PR] Support modifying segmentInfos.counter in IndexWriter [lucene]

guojialiang92 opened a new pull request, #14417: URL: https://github.com/apache/lucene/pull/14417 ### Description This PR aims to address issue [14362](https://github.com/apache/lucene/issues/14362). This issue includes a discussion of the benefits of this modification.