vigyasharma merged PR #14443:
URL: https://github.com/apache/lucene/pull/14443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2869220781
Thanks for the review, @mikemccand . I've updated the PR with changes.
I did a rebase on `main` since it had moved quite a bit. There was no
conflict for the files here, but s
vigyasharma commented on code in PR #14443:
URL: https://github.com/apache/lucene/pull/14443#discussion_r2083302934
##
lucene/core/src/java/org/apache/lucene/search/SearcherManager.java:
##
@@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader,
SearcherFactory sea
vigyasharma commented on code in PR #14443:
URL: https://github.com/apache/lucene/pull/14443#discussion_r2083301651
##
lucene/core/src/java/org/apache/lucene/search/RefreshCommitSupplier.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
vigyasharma commented on code in PR #14443:
URL: https://github.com/apache/lucene/pull/14443#discussion_r2072749702
##
lucene/core/src/java/org/apache/lucene/search/SearcherManager.java:
##
@@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader,
SearcherFactory sea
mikemccand commented on code in PR #14443:
URL: https://github.com/apache/lucene/pull/14443#discussion_r2070345447
##
lucene/core/src/java/org/apache/lucene/search/SearcherManager.java:
##
@@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader,
SearcherFactory sear
mikemccand commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2844952688
> Sorry I'm still a bit confused: how is this approach better than just
committing more frequently, replicating commits as soon as they are created,
and refreshing searchers as soon a
github-actions[bot] commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2832817778
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
vigyasharma commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2798439844
Another scenario where adaptive refresh might be useful is with heterogenous
search fleets. Searchers with less memory would benefit from stepping through
smaller commit deltas, whil
msokolov commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2798221555
> Sorry I'm still a bit confused: how is this approach better than just
committing more frequently, replicating commits as soon as they are created,
and refreshing searchers as soon as
jpountz commented on PR #14443:
URL: https://github.com/apache/lucene/pull/14443#issuecomment-2793132821
Sorry I'm still a bit confused: how is this approach better than just
committing more frequently, replicating commits as soon as they are created,
and refreshing searchers as soon as com
11 matches
Mail list logo
