vigyasharma commented on code in PR #14443: URL: https://github.com/apache/lucene/pull/14443#discussion_r2083302934
########## lucene/core/src/java/org/apache/lucene/search/SearcherManager.java: ########## @@ -131,17 +133,32 @@ public SearcherManager(DirectoryReader reader, SearcherFactory searcherFactory) this.current = getSearcher(searcherFactory, reader, null); } + /** Set supplier for selecting commits to refresh on */ + public void setRefreshCommitSupplier(RefreshCommitSupplier refreshCommitSupplier) { + this.refreshCommitSupplier = refreshCommitSupplier; + } + @Override protected void decRef(IndexSearcher reference) throws IOException { reference.getIndexReader().decRef(); } + /** Return index commit generation for current searcher */ + public long getSearcherCommitGeneration() throws IOException { Review Comment: Good point. I was exposing this as a hook for callers to monitor the searcher commit generation at a point in time, but it could be confusing. It's also just a utility functions that consumers can define outside of this class. Will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org