Re: [PR] Simplify operations by avoiding calculation of extra bitwise operations [lucene]

2025-02-14 Thread via GitHub
giorgigagnidze16 closed pull request #14242: Simplify operations by avoiding calculation of extra bitwise operations URL: https://github.com/apache/lucene/pull/14242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Simplify operations by avoiding calculation of extra bitwise operations [lucene]

2025-02-14 Thread via GitHub
rmuir commented on PR #14242: URL: https://github.com/apache/lucene/pull/14242#issuecomment-2659247757 > Double checking that it works for you too @rmuir? As long as we fix javadocs of VectorSpecies.loopBound to match :) Vector operations loops are not the place to optimize or

Re: [PR] Simplify operations by avoiding calculation of extra bitwise operations [lucene]

2025-02-14 Thread via GitHub
rmuir commented on PR #14242: URL: https://github.com/apache/lucene/pull/14242#issuecomment-2659233974 This was written this way (with a bit of redundancy) on purpose to make it 100% clear it is consistent with `VectorSpecies.loopBound`: > As long as VLENGTH is a power of two, then t

Re: [PR] Simplify operations by avoiding calculation of extra bitwise operations [lucene]

2025-02-14 Thread via GitHub
jpountz commented on PR #14242: URL: https://github.com/apache/lucene/pull/14242#issuecomment-2659075266 Thank you. There shouldn't be any performance difference since I would expect the compiler to pre-compute the result of `~(4-1)` since these are constants, so this change is only about r

[PR] Simplify operations by avoiding calculation of extra bitwise operations [lucene]

2025-02-14 Thread via GitHub
giorgigagnidze16 opened a new pull request, #14242: URL: https://github.com/apache/lucene/pull/14242 ### Description A minor change to eliminate unnecessary bitwise calculations, replaced with actual expected value Example: `int upperBound = a.length & ~(4 - 1); ` -> `int upper