jpountz commented on PR #14242: URL: https://github.com/apache/lucene/pull/14242#issuecomment-2659075266
Thank you. There shouldn't be any performance difference since I would expect the compiler to pre-compute the result of `~(4-1)` since these are constants, so this change is only about readability. The use of negative numbers works for me as a way to convey the number of trailing zeros that are clear, it looks slightly simpler. Double checking that it works for you too @rmuir? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
