jpountz merged PR #14012:
URL: https://github.com/apache/lucene/pull/14012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #14012:
URL: https://github.com/apache/lucene/pull/14012#issuecomment-2515289696
Fair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
msfroh commented on PR #14012:
URL: https://github.com/apache/lucene/pull/14012#issuecomment-2515152818
> Looks good, @msfroh.. Can you also add a Changes entry?
I wasn't planning to add a CHANGES entry. Nothing functionally changes,
there's no optimization. It's just an extremely min
jpountz commented on PR #14012:
URL: https://github.com/apache/lucene/pull/14012#issuecomment-2515030986
@msfroh Do you think you'll have time to add a CHANGES entry? Otherwise I'll
do it for you and merge.
--
This is an automated message from the Apache Git Service.
To respond to the mes
msfroh commented on PR #14012:
URL: https://github.com/apache/lucene/pull/14012#issuecomment-2499037808
Thanks folks! I made the suggested change and took this PR out of draft.
I think this one makes more sense than my previous one over at
https://github.com/apache/lucene/pull/13987
jpountz commented on code in PR #14012:
URL: https://github.com/apache/lucene/pull/14012#discussion_r1856772113
##
lucene/core/src/java/org/apache/lucene/search/ScoreCachingWrappingScorer.java:
##
@@ -31,8 +31,7 @@
*/
public final class ScoreCachingWrappingScorer extends Scor
vigyasharma commented on code in PR #14012:
URL: https://github.com/apache/lucene/pull/14012#discussion_r1855992186
##
lucene/core/src/java/org/apache/lucene/search/ScoreCachingWrappingScorer.java:
##
@@ -31,8 +31,7 @@
*/
public final class ScoreCachingWrappingScorer extends
msfroh opened a new pull request, #14012:
URL: https://github.com/apache/lucene/pull/14012
### Description
This is functionally equivalent to the logic that was present, but makes the
behavior clearer.
--
This is an automated message from the Apache Git Service.
To respond to the m
