jpountz commented on code in PR #14012:
URL: https://github.com/apache/lucene/pull/14012#discussion_r1856772113
##########
lucene/core/src/java/org/apache/lucene/search/ScoreCachingWrappingScorer.java:
##########
@@ -31,8 +31,7 @@
*/
public final class ScoreCachingWrappingScorer extends Scorable {
- private int lastDoc = -1;
- private int curDoc = -1;
+ private boolean computeScore;
Review Comment:
+1 I had a similar reaction when reading this PR. It's easier for me to
reason about when the cached score should be invalidated than when the score
should be computed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
