gf2121 merged PR #13246:
URL: https://github.com/apache/lucene/pull/13246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1549312756
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -85,6 +82,10 @@ public void disableSkipping() {
pruning = Pruning.NONE;
gf2121 commented on PR #13246:
URL: https://github.com/apache/lucene/pull/13246#issuecomment-2027473579
> Out of curiosity, are you seeing a speedup from this change?
On `wikimedium10m`, this patch is slightly faster with little P-value:
```
TaskQPS ba
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544670843
##
lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java:
##
@@ -59,6 +59,11 @@ protected long missingValueAsComparableLong() {
return N
gf2121 commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544668141
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -85,6 +83,16 @@ public void disableSkipping() {
pruning = Pruning.NONE;
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544579639
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -321,42 +307,52 @@ private void updateSkipInterval(boolean success) {
gf2121 opened a new pull request, #13246:
URL: https://github.com/apache/lucene/pull/13246
Simplify complex byte array comparisons as long comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
