jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544670843
##########
lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java:
##########
@@ -59,6 +59,11 @@ protected long missingValueAsComparableLong() {
return NumericUtils.doubleToSortableLong(missingValue);
}
+ @Override
+ protected long sortableBytesToLong(byte[] bytes) {
+ return NumericUtils.sortableBytesToInt(bytes, 0);
Review Comment:
Hmm, should be `long` since doubles are 8-bytes?
```suggestion
return NumericUtils.sortableBytesToLong(bytes, 0);
```
##########
lucene/core/src/java/org/apache/lucene/search/comparators/IntComparator.java:
##########
@@ -58,6 +59,11 @@ protected long missingValueAsComparableLong() {
return missingValue;
}
+ @Override
+ protected long sortableBytesToLong(byte[] bytes) {
+ return NumericUtils.sortableBytesToLong(bytes, 0);
Review Comment:
ToInt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
