jpountz closed pull request #12838: Simplify advancing on postings/impacts enums
URL: https://github.com/apache/lucene/pull/12838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #12838:
URL: https://github.com/apache/lucene/pull/12838#issuecomment-1880899639
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jpountz commented on code in PR #12838:
URL: https://github.com/apache/lucene/pull/12838#discussion_r1404365624
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipReader.java:
##
@@ -48,7 +48,7 @@
*
* Therefore, we'll trim df before passing it to the inter
gf2121 commented on code in PR #12838:
URL: https://github.com/apache/lucene/pull/12838#discussion_r1404145355
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipReader.java:
##
@@ -48,7 +48,7 @@
*
* Therefore, we'll trim df before passing it to the interf
gf2121 commented on code in PR #12838:
URL: https://github.com/apache/lucene/pull/12838#discussion_r1404145355
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipReader.java:
##
@@ -48,7 +48,7 @@
*
* Therefore, we'll trim df before passing it to the interf
jpountz opened a new pull request, #12838:
URL: https://github.com/apache/lucene/pull/12838
This is a new iteration on #12810, which I had to revert because of test
failures when docFreq is a multiple of 128.
We currently have a hack when the doc freq is not a multiple of 128 in order
jpountz merged PR #12810:
URL: https://github.com/apache/lucene/pull/12810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #12810:
URL: https://github.com/apache/lucene/pull/12810#issuecomment-1824353933
I'll merge to make sure it gets some time in CI before we cut a release.
Feel free to raise concerns after merging if you have any, I'll happily address
them and revert if necessary.
-
jpountz commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1403032682
##
lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java:
##
@@ -63,7 +63,7 @@ public abstract class MultiLevelSkipListReader implements
Closeab
jpountz commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1403031948
##
lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java:
##
@@ -63,7 +63,7 @@ public abstract class MultiLevelSkipListReader implements
Closeab
gf2121 commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1402985278
##
lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java:
##
@@ -63,7 +63,7 @@ public abstract class MultiLevelSkipListReader implements
Closeabl
jpountz commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1402438164
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/LegacyMultiLevelSkipListReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software
gf2121 commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1401710042
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/LegacyMultiLevelSkipListReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software F
jpountz commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1401733088
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/LegacyMultiLevelSkipListReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software
gf2121 commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1401710042
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/LegacyMultiLevelSkipListReader.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software F
jpountz commented on PR #12810:
URL: https://github.com/apache/lucene/pull/12810#issuecomment-1818507017
@mikemccand Since you are familiar with postings, would you mind having a
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
msokolov commented on PR #12810:
URL: https://github.com/apache/lucene/pull/12810#issuecomment-1812678173
this sounds reasonable to me, and the code does seem simpler, but I'm not
able to give a thorough review. +1 to rationalize / simplify even if it doesn't
show significant peformance imp
jpountz commented on PR #12810:
URL: https://github.com/apache/lucene/pull/12810#issuecomment-1812099057
For reference, starting postings and skip lists at -1 changes file formats,
so I'm keen to getting this change in 9.9 since we had to change the file
format anyway because of the move fr
jpountz commented on PR #12810:
URL: https://github.com/apache/lucene/pull/12810#issuecomment-1812097551
This change seems to be neutral on wikibigall. No speedup, but not slowdown
either.
```
TaskQPS baseline StdDevQPS
my_modified_version Std
jpountz opened a new pull request, #12810:
URL: https://github.com/apache/lucene/pull/12810
Currently `advance(int target)` needs to perform two checks:
- is there a need to use skip lists?
- is there a need for decoding a new block?
Ideally we would track the last doc ID in a
20 matches
Mail list logo
