gf2121 commented on code in PR #12810:
URL: https://github.com/apache/lucene/pull/12810#discussion_r1402985278
##########
lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java:
##########
@@ -63,7 +63,7 @@ public abstract class MultiLevelSkipListReader implements
Closeable {
protected int[] skipDoc;
/** Doc id of last read skip entry with docId <= target. */
- private int lastDoc;
+ private int lastDoc = -1;
Review Comment:
Not sure if it is worth concern:
This is a very expert class but since it is declared public, there could
probably be some custom `PostingsFormat` using it. Their file format will get
changed silently when users upgrade to 9.9.0. I wonder if we can rename this
new `MultiLevelSkipListReader` to `Lucene99MultiLevelSkipListReader` to help
users at least get a compile error, and it seems more consistent with the
`Lucene50MultiLevelSkipListReader` as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
