Re: [PR] Run merge-on-full-flush even though no changes got flushed. [lucene]

2023-10-25 Thread via GitHub
jpountz commented on PR #12549: URL: https://github.com/apache/lucene/pull/12549#issuecomment-1779816530 I ended up implementing your other suggestion. MDW generally expects that this IndexWriter instantiation will not do merges. -- This is an automated message from the Apache Git Service

Re: [PR] Run merge-on-full-flush even though no changes got flushed. [lucene]

2023-10-25 Thread via GitHub
jpountz commented on PR #12549: URL: https://github.com/apache/lucene/pull/12549#issuecomment-1779155292 Thanks! I was thinking of something along the lines of the diff you shared, I had not thought of the SerialMergeScheduler approach. I'll check it works and push this change. -- This i

Re: [PR] Run merge-on-full-flush even though no changes got flushed. [lucene]

2023-10-25 Thread via GitHub
s1monw commented on PR #12549: URL: https://github.com/apache/lucene/pull/12549#issuecomment-1778953836 I think this is only triggered because of your change but the problem was already there. We hold the lock in MDW#close() such that we can not run a concurrent merge. We could either preve

Re: [PR] Run merge-on-full-flush even though no changes got flushed. [lucene]

2023-10-24 Thread via GitHub
jpountz commented on PR #12549: URL: https://github.com/apache/lucene/pull/12549#issuecomment-1777530886 I reverted as this causes a deadlock in TestStressIndexing: ``` "TEST-TestStressIndexing.testStressIndexAndSearching-seed#[D4B60FA81EB58FF3]" #42 [282516] prio=5 os_prio=0 cpu=

Re: [PR] Run merge-on-full-flush even though no changes got flushed. [lucene]

2023-10-24 Thread via GitHub
jpountz merged PR #12549: URL: https://github.com/apache/lucene/pull/12549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa