jpountz commented on PR #12549:
URL: https://github.com/apache/lucene/pull/12549#issuecomment-1777530886
I reverted as this causes a deadlock in TestStressIndexing:
```
"TEST-TestStressIndexing.testStressIndexAndSearching-seed#[D4B60FA81EB58FF3]"
#42 [282516] prio=5 os_prio=0 cpu=314.69ms elapsed=8.44s tid=0x00007f9144078860
nid=282516 in Object.wait() [0x00007f9195122000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait0(java.base@21/Native Method)
- waiting on <0x00000006207504f0> (a
org.apache.lucene.index.IndexWriter)
at java.lang.Object.wait(java.base@21/Object.java:366)
at org.apache.lucene.index.IndexWriter.doWait(IndexWriter.java:5419)
- locked <0x00000006207504f0> (a org.apache.lucene.index.IndexWriter)
at
org.apache.lucene.index.IndexWriter.abortMerges(IndexWriter.java:2723)
- locked <0x00000006207504f0> (a org.apache.lucene.index.IndexWriter)
at
org.apache.lucene.index.IndexWriter.rollbackInternalNoCommit(IndexWriter.java:2471)
- locked <0x00000006207504f0> (a org.apache.lucene.index.IndexWriter)
at
org.apache.lucene.index.IndexWriter.rollbackInternal(IndexWriter.java:2451)
- locked <0x0000000620750a88> (a java.lang.Object)
at org.apache.lucene.index.IndexWriter.shutdown(IndexWriter.java:1336)
at org.apache.lucene.index.IndexWriter.close(IndexWriter.java:1364)
at
org.apache.lucene.tests.store.MockDirectoryWrapper.close(MockDirectoryWrapper.java:973)
- locked <0x000000062702c9f8> (a
org.apache.lucene.tests.store.MockDirectoryWrapper)
at
org.apache.lucene.index.TestStressIndexing.testStressIndexAndSearching(TestStressIndexing.java:171)
at
java.lang.invoke.LambdaForm$DMH/0x00007f919810d000.invokeVirtual(java.base@21/LambdaForm$DMH)
at
java.lang.invoke.LambdaForm$MH/0x00007f919810d400.invoke(java.base@21/LambdaForm$MH)
at
java.lang.invoke.Invokers$Holder.invokeExact_MT(java.base@21/Invokers$Holder)
at
jdk.internal.reflect.DirectMethodHandleAccessor.invokeImpl(java.base@21/DirectMethodHandleAccessor.java:153)
at
jdk.internal.reflect.DirectMethodHandleAccessor.invoke(java.base@21/DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke(java.base@21/Method.java:580)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at
org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
at
org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at
org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
at
com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at
com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at
org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at
org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at
org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at
org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at
org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
at
com.carrotsearch.randomizedtesting.ThreadLeakControl$$Lambda/0x00007f919808ed60.run(Unknown
Source)
at java.lang.Thread.runWith(java.base@21/Thread.java:1596)
at java.lang.Thread.run(java.base@21/Thread.java:1583)
"Lucene Merge Thread #0" #53 [282533] daemon prio=5 os_prio=0 cpu=1.59ms
elapsed=7.81s tid=0x00007f910815ee70 nid=282533 waiting for monitor entry
[0x00007f9195022000]
java.lang.Thread.State: BLOCKED (on object monitor)
at
org.apache.lucene.tests.store.MockDirectoryWrapper.createOutput(MockDirectoryWrapper.java:692)
- waiting to lock <0x000000062702c9f8> (a
org.apache.lucene.tests.store.MockDirectoryWrapper)
at
org.apache.lucene.store.LockValidatingDirectoryWrapper.createOutput(LockValidatingDirectoryWrapper.java:43)
at
org.apache.lucene.index.ConcurrentMergeScheduler$2.createOutput(ConcurrentMergeScheduler.java:290)
at
org.apache.lucene.store.TrackingDirectoryWrapper.createOutput(TrackingDirectoryWrapper.java:41)
at
org.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsWriter.<init>(Lucene90CompressingStoredFieldsWriter.java:130)
at
org.apache.lucene.codecs.lucene90.compressing.Lucene90CompressingStoredFieldsFormat.fieldsWriter(Lucene90CompressingStoredFieldsFormat.java:140)
at
org.apache.lucene.codecs.lucene90.Lucene90StoredFieldsFormat.fieldsWriter(Lucene90StoredFieldsFormat.java:154)
at
org.apache.lucene.index.SegmentMerger.mergeFields(SegmentMerger.java:233)
at
org.apache.lucene.index.SegmentMerger$$Lambda/0x00007f91981801f8.merge(Unknown
Source)
at
org.apache.lucene.index.SegmentMerger.mergeWithLogging(SegmentMerger.java:273)
at org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:110)
at
org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:5172)
at org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4705)
at
org.apache.lucene.index.IndexWriter$IndexWriterMergeSource.merge(IndexWriter.java:6460)
at
org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:639)
at
org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:700)
```
This seems to be more a problem with `MockDirectoryWrapper` than with the
change to me, though I'm unsure how to fix MDW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
