jpountz merged PR #13763:
URL: https://github.com/apache/lucene/pull/13763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
bugmakerr commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2416803313
@jpountz I have merged main branch, PTAL:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bugmakerr commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1803076020
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState read
bugmakerr commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2414387606
> Would you like to make this PR up-to-date and open a new one for the other
change (a cherry-pick isn't clean due to other changes)?
@jpountz sure, I‘d be happy to do this.
jpountz commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2414051812
Would you like to make this PR up-to-date and open a new one for the other
change (a cherry-pick isn't clean due to other changes)?
--
This is an automated message from the Apache Git
jpountz commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2414048312
Yes, let's add this in 10.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bugmakerr commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2410922885
hi @jpountz ,since we have moved to lucene 10, should we merge this and add
back #13686?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
jpountz commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1765286133
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState readState)
jpountz commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1765280863
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState readState)
bugmakerr commented on PR #13763:
URL: https://github.com/apache/lucene/pull/13763#issuecomment-2349265068
@benwtrent @jpountz I have merged main branch into this one, can I get a
review on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
bugmakerr commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1756317165
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState read
jpountz commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754532585
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState readState)
jpountz commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754526036
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##
@@ -223,7 +224,8 @@ public void checkIntegrity() throw
bugmakerr commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754506971
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##
@@ -223,7 +224,8 @@ public void checkIntegrity()
bugmakerr commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754495787
##
lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java:
##
@@ -239,51 +245,69 @@ public FieldsReader(final SegmentReadState read
benwtrent commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754484940
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##
@@ -223,7 +224,8 @@ public void checkIntegrity() thr
bugmakerr opened a new pull request, #13763:
URL: https://github.com/apache/lucene/pull/13763
### Description
Following up on #13686.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
17 matches
Mail list logo
