jpountz commented on code in PR #13763:
URL: https://github.com/apache/lucene/pull/13763#discussion_r1754526036
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##########
@@ -223,7 +224,8 @@ public void checkIntegrity() throws IOException {
@Override
public FloatVectorValues getFloatVectorValues(String field) throws
IOException {
- FieldEntry fieldEntry = fields.get(field);
+ final FieldInfo info = fieldInfos.fieldInfo(field);
Review Comment:
In my opinion, the most important thing is to remove the leniency we have in
some places, like `if (fieldEntry == null) return EMPTY_VECTOR_VALUES`, which
could hide bugs. Checking for null explicitly is not required, though it's
obviously nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
