Re: [PR] Removing unnecessary splitX in ComponentTree [lucene]

2025-04-11 Thread via GitHub
rmuir commented on PR #14476: URL: https://github.com/apache/lucene/pull/14476#issuecomment-2797897063 Thank you @jainankitk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Removing unnecessary splitX in ComponentTree [lucene]

2025-04-11 Thread via GitHub
rmuir merged PR #14476: URL: https://github.com/apache/lucene/pull/14476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] Removing unnecessary splitX in ComponentTree [lucene]

2025-04-11 Thread via GitHub
jainankitk commented on code in PR #14476: URL: https://github.com/apache/lucene/pull/14476#discussion_r2039927980 ## lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java: ## @@ -48,23 +50,18 @@ final class ComponentTree implements Component2D { // child components,

[PR] Removing unnecessary splitX in ComponentTree [lucene]

2025-04-11 Thread via GitHub
jainankitk opened a new pull request, #14476: URL: https://github.com/apache/lucene/pull/14476 ### Description IMO, storing splitX for every `TreeNode` makes sense, only if we are exposing API to partially search `ComponentTree` from arbitrary `TreeNode` which is not allowed today. Hence