jainankitk commented on code in PR #14476:
URL: https://github.com/apache/lucene/pull/14476#discussion_r2039927980
##########
lucene/core/src/java/org/apache/lucene/geo/ComponentTree.java:
##########
@@ -48,23 +50,18 @@ final class ComponentTree implements Component2D {
// child components, or null. Note internal nodes might mot have
// a consistent bounding box. Internal nodes should not be accessed
// outside if this class.
- private Component2D left;
- private Component2D right;
-
- /** which dimension was this node split on */
- // TODO: its implicit based on level, but boolean keeps code simple
- private final boolean splitX;
+ private ComponentTree left;
+ private ComponentTree right;
Review Comment:
left, right should always be `ComponentTree` to indicate the recursive
structure. While `Component2D` worked as `ComponentTree` implements the
interface, but plugging in arbitrary implementation of `Component2D` here won't
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
