Re: [PR] Remove TopScoreDocCollector's dependency on HitsThresholdChecker. [lucene]

2024-10-23 Thread via GitHub
jpountz commented on PR #13943: URL: https://github.com/apache/lucene/pull/13943#issuecomment-2432246400 Actually, while I was at it, I also removed `TopFieldCollector`'s dependency on HitsThresholdChecker, and then removed `HitsThresholdChecker`. ``` Ta

Re: [PR] Remove TopScoreDocCollector's dependency on HitsThresholdChecker. [lucene]

2024-10-22 Thread via GitHub
jpountz commented on PR #13943: URL: https://github.com/apache/lucene/pull/13943#issuecomment-2429765576 wikibigall with a `searchConcurrency` of 8 suggests that the slowdown is tiny: ``` TaskQPS baseline StdDevQPS my_modified_version StdDev

[PR] Remove TopScoreDocCollector's dependency on HitsThresholdChecker. [lucene]

2024-10-22 Thread via GitHub
jpountz opened a new pull request, #13943: URL: https://github.com/apache/lucene/pull/13943 `TopScoreDocCollectorManager` has a dependency on `HitsThresholdChecker`, which is essentially a shared counter that is incremented until it reaches the total hits threshold, when the scorer can star