jpountz commented on PR #13943: URL: https://github.com/apache/lucene/pull/13943#issuecomment-2432246400
Actually, while I was at it, I also removed `TopFieldCollector`'s dependency on HitsThresholdChecker, and then removed `HitsThresholdChecker`. ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value And2Terms2StopWords 189.12 (4.5%) 182.81 (4.2%) -3.3% ( -11% - 5%) 0.015 AndStopWords 67.12 (4.6%) 66.00 (3.8%) -1.7% ( -9% - 7%) 0.214 OrStopWords 70.79 (6.9%) 69.97 (7.2%) -1.1% ( -14% - 13%) 0.607 CountTerm 8165.89 (5.6%) 8090.18 (3.8%) -0.9% ( -9% - 8%) 0.538 Wildcard 133.39 (4.1%) 132.24 (3.3%) -0.9% ( -7% - 6%) 0.468 Or2Terms2StopWords 194.66 (5.4%) 193.42 (4.1%) -0.6% ( -9% - 9%) 0.673 OrHighMed 198.12 (4.1%) 197.08 (3.5%) -0.5% ( -7% - 7%) 0.663 And3Terms 180.61 (4.0%) 179.74 (3.9%) -0.5% ( -8% - 7%) 0.700 CountAndHighMed 163.62 (4.5%) 163.28 (3.5%) -0.2% ( -7% - 8%) 0.872 Fuzzy1 78.71 (2.3%) 78.63 (1.8%) -0.1% ( -4% - 4%) 0.881 AndHighMed 160.23 (4.9%) 160.16 (4.4%) -0.0% ( -8% - 9%) 0.974 OrHighHigh 103.71 (4.1%) 103.68 (4.2%) -0.0% ( -8% - 8%) 0.981 OrMany 46.85 (2.4%) 46.85 (2.7%) -0.0% ( -5% - 5%) 0.996 CountOrHighMed 139.92 (4.2%) 139.96 (4.7%) 0.0% ( -8% - 9%) 0.984 PKLookup 278.34 (2.4%) 278.47 (2.5%) 0.0% ( -4% - 5%) 0.950 Or3Terms 176.21 (3.8%) 176.43 (2.9%) 0.1% ( -6% - 7%) 0.904 Fuzzy2 74.40 (2.5%) 74.65 (2.0%) 0.3% ( -4% - 4%) 0.647 CountAndHighHigh 76.54 (4.8%) 76.82 (4.1%) 0.4% ( -8% - 9%) 0.798 AndHighHigh 96.45 (5.3%) 96.82 (4.3%) 0.4% ( -8% - 10%) 0.800 OrNotHighHigh 200.33 (3.1%) 201.39 (4.6%) 0.5% ( -6% - 8%) 0.667 AndHighLow 1013.59 (2.4%) 1019.06 (2.4%) 0.5% ( -4% - 5%) 0.480 HighTermTitleSort 72.60 (3.3%) 73.08 (3.5%) 0.7% ( -5% - 7%) 0.540 Prefix3 191.90 (5.3%) 193.31 (4.5%) 0.7% ( -8% - 11%) 0.635 OrHighNotHigh 198.74 (2.8%) 200.40 (4.1%) 0.8% ( -5% - 7%) 0.452 IntNRQ 125.30 (11.9%) 126.54 (9.9%) 1.0% ( -18% - 25%) 0.776 OrHighNotMed 281.15 (2.4%) 284.02 (5.0%) 1.0% ( -6% - 8%) 0.407 HighTermDayOfYearSort 255.46 (3.2%) 258.19 (3.8%) 1.1% ( -5% - 8%) 0.333 CountOrHighHigh 90.76 (5.7%) 91.74 (5.1%) 1.1% ( -9% - 12%) 0.529 OrNotHighMed 326.08 (3.7%) 329.84 (4.8%) 1.2% ( -7% - 10%) 0.396 OrHighLow 786.85 (1.8%) 797.01 (2.7%) 1.3% ( -3% - 5%) 0.076 OrHighNotLow 368.40 (2.5%) 373.79 (5.3%) 1.5% ( -6% - 9%) 0.265 HighTermTitleBDVSort 57.32 (4.3%) 58.16 (4.0%) 1.5% ( -6% - 10%) 0.268 OrNotHighLow 1096.17 (3.0%) 1114.86 (3.0%) 1.7% ( -4% - 7%) 0.071 HighTerm 338.49 (2.5%) 347.01 (2.5%) 2.5% ( -2% - 7%) 0.001 LowTerm 663.36 (3.3%) 682.20 (3.4%) 2.8% ( -3% - 9%) 0.008 OrHighRare 246.60 (6.2%) 253.61 (7.7%) 2.8% ( -10% - 17%) 0.198 MedTerm 433.32 (3.0%) 445.99 (3.1%) 2.9% ( -3% - 9%) 0.003 TermDTSort 196.52 (3.4%) 219.52 (4.9%) 11.7% ( 3% - 20%) 0.000 HighTermMonthSort 1082.56 (2.7%) 1404.25 (3.4%) 29.7% ( 22% - 36%) 0.000 ``` Queries sorted by field seem to benefit from the lesser synchronization across search threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org