Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2040500344 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

jainankitk commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2039940112 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

jainankitk commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2039939835 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2039417117 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2038934742 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

jainankitk commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2038859997 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -819,17 +819,11 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2038747491 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws IOException { /

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

jainankitk commented on code in PR #13923: URL: https://github.com/apache/lucene/pull/13923#discussion_r2037877322 ## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ## @@ -828,7 +828,8 @@ private void freezeTail(int prefixLenPlus1) throws IOException {

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 commented on PR #13923: URL: https://github.com/apache/lucene/pull/13923#issuecomment-2791946674 Please take a look when you get a chance @mikemccand . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

github-actions[bot] commented on PR #13923: URL: https://github.com/apache/lucene/pull/13923#issuecomment-2451063955 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

vsop-479 opened a new pull request, #13923: URL: https://github.com/apache/lucene/pull/13923 ### Description `node.numArcs == 0` happens on the last node(I think we fake it) of a input. But we set it `isFinal`, so we still can remove `node.numArcs == 0`. -- This is an automate