zhaih merged PR #12910:
URL: https://github.com/apache/lucene/pull/12910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
zhaih commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1424037388
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -51,45 +51,61 @@ public NeighborArray(int maxSize, boolean descOrder) {
*/
public vo
zhaih commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1424036233
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -51,45 +51,61 @@ public NeighborArray(int maxSize, boolean descOrder) {
*/
public vo
zhaih commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1424031699
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -51,45 +51,61 @@ public NeighborArray(int maxSize, boolean descOrder) {
*/
public vo
zhaih commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1424029197
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -201,9 +225,69 @@ private int descSortFindRightMostInsertionPoint(float
newScore, int boun
zhaih commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1424022318
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -34,14 +34,14 @@
public class NeighborArray {
private final boolean scoresDescOrder;
benwtrent commented on code in PR #12910:
URL: https://github.com/apache/lucene/pull/12910#discussion_r1422799676
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -201,9 +225,69 @@ private int descSortFindRightMostInsertionPoint(float
newScore, int
zhaih opened a new pull request, #12910:
URL: https://github.com/apache/lucene/pull/12910
### Description
Not a huge refactor, basically:
1. Not share field (`nodes/scores`) outside
2. Move diversity check inside NeighborArray such that no one outside should
tell Neighbo
