zhaih opened a new pull request, #12910:
URL: https://github.com/apache/lucene/pull/12910

   ### Description
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   
   Not a huge refactor, basically:
   1. Not share field (`nodes/scores`) outside
   2. Move diversity check inside NeighborArray such that no one outside should 
tell NeighborArray which element to delete
   3. Restrict more method from being `public` after 2
   
   Such that I think would help further abstraction in the future to have a 
concurrent version of NeighborArray.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to