Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

jainankitk commented on PR #14267: URL: https://github.com/apache/lucene/pull/14267#issuecomment-2773131906 @hanbj - Thanks for patiently addressing the review comments. While I don't see any performance regression risk myself, I am wondering if we can do one quick performance benchmark run

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2026298155 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -517,6 +623,11 @@ public byte[] getUpperPoint() { return upperPoint.clone(); }

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2026298829 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -120,381 +132,475 @@ public void visit(QueryVisitor visitor) { public final Weight c

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

gsmiller commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2025592245 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -517,6 +623,11 @@ public byte[] getUpperPoint() { return upperPoint.clone(); }

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

hanbj commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2024183379 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -120,381 +132,447 @@ public void visit(QueryVisitor visitor) { public final Weight create

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2023189174 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -120,381 +132,447 @@ public void visit(QueryVisitor visitor) { public final Weight c

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

hanbj commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2022373498 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -129,6 +141,16 @@ public final Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

hanbj commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2022373498 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -129,6 +141,16 @@ public final Weight createWeight(IndexSearcher searcher, ScoreMode scoreM

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2021794022 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -129,6 +141,16 @@ public final Weight createWeight(IndexSearcher searcher, ScoreMode s

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

github-actions[bot] commented on PR #14267: URL: https://github.com/apache/lucene/pull/14267#issuecomment-2759877138 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

hanbj commented on PR #14267: URL: https://github.com/apache/lucene/pull/14267#issuecomment-2716944118 The previous failed test case was org.apache.Lucene.index TestKnnGraph.testMultiThreadedSearch. I have confirmed the testMultiThreadedSearch method, which uses KnnFloatVectorQuery for s

[PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

hanbj opened a new pull request, #14267: URL: https://github.com/apache/lucene/pull/14267 ### Description When lowerPoint is equal to upperPoint. In fact, there is no need to compare lowerPoint and upperPoint at the same time. The number of comparisons can be reduced by half when collect