vigyasharma closed pull request #14325: Optimize commit retention policy to
maintain only the last 5 commits
URL: https://github.com/apache/lucene/pull/14325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
vigyasharma commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2781125749
This PR changes the existing `KeepLastCommitDeletionPolicy` which is not
what we want. I've created a new, beginner issue, #1 that specifies the
requirements from this task.
--
github-actions[bot] commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2767713463
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
vigyasharma commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2728289419
+1 to Adrien's comment, IndexDeletionPolicy can quite easily be implemented
and configured by users in IndexWriterConfig. It if often configured outside of
Lucene too, like the
[Com
jpountz commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2705668964
@DivyanshIITB Deletion policies are configurable via
`IndexWriterConfig#setIndexDeletionPolicy`, see e.g. `SnapshotDeletionPolicy`
which allows for finer-grained maintenance of snapshots
DivyanshIITB commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2696661645
Thank you for your feedback! I understand your concern that
KeepOnlyLastCommit might imply retaining only a single commit. My intention
behind modifying this policy to retain the la
rmuir commented on PR #14325:
URL: https://github.com/apache/lucene/pull/14325#issuecomment-2694353271
To me, KeepOnlyLastCommit means only the last commit, not the last 5. I
don't think this policy should be modified like this.
--
This is an automated message from the Apache Git Service
DivyanshIITB closed pull request #14323: Optimize commit retention policy to
maintain only the last 5 commits
URL: https://github.com/apache/lucene/pull/14323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
