vigyasharma commented on PR #14325: URL: https://github.com/apache/lucene/pull/14325#issuecomment-2728289419
+1 to Adrien's comment, IndexDeletionPolicy can quite easily be implemented and configured by users in IndexWriterConfig. It if often configured outside of Lucene too, like the [CombinedDeletionPolicy](https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/index/engine/CombinedDeletionPolicy.java) in OpenSearch and Elasticsearch. @DivyanshIITB Incidentally, I've recently been working on a segment replication optimization (#14219 ) that could benefit from keeping the last N commits in the index. Ah, I see you already linked this PR to that issue. I would suggest you to create a separate IndexDeletionPolicy for this. You could also allow users to configure the `N` commits they want to retain instead of fixing it to 5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
