Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-05-24 Thread via GitHub
github-actions[bot] commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2907524124 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-05-10 Thread via GitHub
vigyasharma commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2869263962 Bumping up since the PR went stale. Should I finalize the changes in #14486 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-04-28 Thread via GitHub
github-actions[bot] commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2837101314 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-04-14 Thread via GitHub
vigyasharma commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2802966023 I hacked together a prototype impl. for a reference managed `MultiReader`. I can add some tests and clean it up if this meets our requirements. – https://github.com/apache/lucene/pu

Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-04-12 Thread via GitHub
vigyasharma commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2799023243 > I have been wondering if we should remove `SearcherManager` and encourage users to use `IndexReaderManager` We could start encouraging people to use the existing `ReaderManag

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-27 Thread via GitHub
github-actions[bot] commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2505040108 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-13 Thread via GitHub
jpountz commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2472800472 To add to @vigyasharma, I have been wondering if we should remove `SearcherManager` and encourage users to use `IndexReaderManager`. `IndexSearcher` is cheap to create and there are som

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-07 Thread via GitHub
vigyasharma commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2463936596 > any `IndexReader` should work as long as it can `openIfChanged` on itself. Does `MultiReader` implement `openIfChanged()` ? I see a check in `SearcherManager#refreshIfNeeded(

Re: [PR] Multireader Support in Searcher Manager [lucene]

2024-11-04 Thread via GitHub
mikemccand commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2455571526 Thanks @Shibi-bala -- I agree it's odd it was scoped to just `DirectoryReader` -- any `IndexReader` should work as long as it can `openIfChanged` on itself. I think `English.ja

[PR] Multireader Support in Searcher Manager [lucene]

2024-11-04 Thread via GitHub
Shibi-bala opened a new pull request, #13976: URL: https://github.com/apache/lucene/pull/13976 ### Description Copied from https://github.com/apache/lucene/issues/13975 I'd like to use MultiReader inside my searcher manager, but currently there is only support for DirectoryRead