gf2121 commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2942786427
> Since the top-k heap appears to be a bottleneck for some queries, we could
look into whether a radix heap would perform better than a binary heap in a
follow-up.
+1, that would b
jpountz commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2938964435
Since the top-k heap appears to be a bottleneck for some queries, we could
look into whether a radix heap would perform better than a binary heap in a
follow-up.
--
This is an automat
gf2121 commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2125750621
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
pr
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2124848870
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
p
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2124821293
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -32,31 +34,21 @@
public class TopScoreDocCollector extends TopDocsCollector {
p
gf2121 commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2113866926
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -73,23 +65,22 @@ public ScoreMode scoreMode() {
public LeafCollector getLeafCollect
gf2121 commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2113858109
##
lucene/core/src/java/org/apache/lucene/search/DocScoreEncoder.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jpountz commented on code in PR #14714:
URL: https://github.com/apache/lucene/pull/14714#discussion_r2111945886
##
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##
@@ -73,23 +65,22 @@ public ScoreMode scoreMode() {
public LeafCollector getLeafCollec
jpountz commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2913896479
I wasn't aware of this indeed. OK for passing null then, I agree that there
may be sub classes that rely on this API in the wild.
--
This is an automated message from the Apache Git Se
gf2121 commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2913036055
Thanks for the suggestion!
> It's a bit ugly to pass null as a HitQueue in the constructor of
TopScoreDocCollector. Can we only keep method signatures on TopDocsCollector
and move
github-actions[bot] commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2908907735
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog-check
label to it and you wil
gf2121 opened a new pull request, #14714:
URL: https://github.com/apache/lucene/pull/14714
This tries to encode `ScoreDoc#score` and `ScoreDoc#doc` to a comparable
long and use a `LongHeap` instead of `HitQueue`. This seems to help apparently
when i increase `topN = 1000`
(https://github.c
12 matches
Mail list logo
