gf2121 commented on PR #14714:
URL: https://github.com/apache/lucene/pull/14714#issuecomment-2942786427
> Since the top-k heap appears to be a bottleneck for some queries, we could
look into whether a radix heap would perform better than a binary heap in a
follow-up.
+1, that would be an interesting exploration!
I rechecked benchmark against newest main (topN=1000), i plan to merge soon.
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
AndStopWords 11.62 (8.3%) 11.35
(11.4%) -2.4% ( -20% - 19%) 0.582
FilteredAndHighHigh 20.84 (5.6%) 20.50
(6.6%) -1.6% ( -13% - 11%) 0.532
FilteredAndStopWords 17.33 (5.1%) 17.07
(6.5%) -1.5% ( -12% - 10%) 0.549
CountTerm 14997.16 (3.8%) 14843.44
(2.4%) -1.0% ( -6% - 5%) 0.447
CountFilteredOrHighMed 49.85 (4.3%) 49.49
(4.4%) -0.7% ( -9% - 8%) 0.696
OrStopWords 11.79 (7.9%) 11.71
(12.6%) -0.7% ( -19% - 21%) 0.881
FilteredAndHighMed 64.40 (4.8%) 64.00
(5.8%) -0.6% ( -10% - 10%) 0.784
CountFilteredOrHighHigh 40.31 (3.5%) 40.10
(3.7%) -0.5% ( -7% - 6%) 0.728
CountAndHighMed 123.05 (2.3%) 122.52
(3.3%) -0.4% ( -5% - 5%) 0.722
CountFilteredPhrase 22.36 (1.7%) 22.27
(1.7%) -0.4% ( -3% - 3%) 0.553
CountFilteredOrMany 10.61 (3.9%) 10.57
(4.7%) -0.4% ( -8% - 8%) 0.816
CountAndHighHigh 84.09 (2.8%) 83.81
(2.8%) -0.3% ( -5% - 5%) 0.779
Respell 80.92 (2.7%) 80.67
(3.0%) -0.3% ( -5% - 5%) 0.804
CountOrHighMed 157.52 (1.2%) 157.12
(2.3%) -0.3% ( -3% - 3%) 0.750
CountOrHighHigh 88.38 (2.7%) 88.25
(3.4%) -0.1% ( -6% - 6%) 0.911
FilteredOrMany 5.16 (1.6%) 5.16
(1.1%) -0.0% ( -2% - 2%) 0.961
FilteredAnd2Terms2StopWords 129.21 (2.8%) 129.21
(4.2%) -0.0% ( -6% - 7%) 1.000
TermTitleSort 42.03 (2.0%) 42.07
(2.0%) 0.1% ( -3% - 4%) 0.922
And3Terms 123.28 (5.1%) 123.64
(7.0%) 0.3% ( -11% - 13%) 0.911
FilteredPhrase 21.66 (1.8%) 21.76
(1.8%) 0.5% ( -3% - 4%) 0.532
AndHighHigh 30.49 (3.0%) 30.66
(2.9%) 0.6% ( -5% - 6%) 0.653
TermDayOfYearSort 143.65 (2.3%) 144.57
(2.5%) 0.6% ( -4% - 5%) 0.535
TermDTSort 126.92 (2.3%) 128.15
(1.5%) 1.0% ( -2% - 4%) 0.249
OrMany 6.74 (8.5%) 6.81
(10.1%) 1.0% ( -16% - 21%) 0.806
Phrase 10.82 (1.5%) 10.92
(3.1%) 1.0% ( -3% - 5%) 0.346
Wildcard 117.72 (1.8%) 118.92
(1.7%) 1.0% ( -2% - 4%) 0.176
CombinedAndHighHigh 9.55 (2.3%) 9.68
(1.3%) 1.4% ( -2% - 5%) 0.087
FilteredOr3Terms 40.65 (2.9%) 41.23
(2.1%) 1.4% ( -3% - 6%) 0.181
FilteredAnd3Terms 180.65 (3.2%) 183.26
(2.8%) 1.4% ( -4% - 7%) 0.259
FilteredOrHighHigh 25.16 (1.8%) 25.54
(1.4%) 1.5% ( -1% - 4%) 0.024
And2Terms2StopWords 113.61 (4.1%) 115.35
(6.9%) 1.5% ( -9% - 13%) 0.527
CountOrMany 11.61 (5.8%) 11.79
(5.8%) 1.5% ( -9% - 14%) 0.534
Fuzzy2 82.73 (3.8%) 84.06
(3.9%) 1.6% ( -5% - 9%) 0.328
TermMonthSort 1752.96 (2.5%) 1781.58
(2.2%) 1.6% ( -2% - 6%) 0.104
AndHighOrMedMed 28.81 (2.5%) 29.31
(2.8%) 1.7% ( -3% - 7%) 0.130
CombinedOrHighHigh 9.75 (2.5%) 9.94
(1.9%) 1.9% ( -2% - 6%) 0.043
CombinedTerm 20.68 (2.6%) 21.09
(1.6%) 2.0% ( -2% - 6%) 0.029
AndHighMed 81.85 (3.4%) 83.52
(3.7%) 2.0% ( -4% - 9%) 0.178
AndMedOrHighHigh 35.62 (2.0%) 36.35
(2.0%) 2.0% ( -1% - 6%) 0.017
FilteredOrStopWords 17.06 (3.1%) 17.41
(2.3%) 2.1% ( -3% - 7%) 0.076
Fuzzy1 83.47 (4.2%) 85.27
(4.3%) 2.2% ( -6% - 11%) 0.236
FilteredPrefix3 166.77 (1.5%) 170.92
(1.4%) 2.5% ( 0% - 5%) 0.000
OrHighHigh 32.88 (2.3%) 33.75
(4.0%) 2.6% ( -3% - 9%) 0.057
CombinedAndHighMed 42.14 (1.8%) 43.29
(1.2%) 2.7% ( 0% - 5%) 0.000
Prefix3 179.69 (1.6%) 184.81
(1.6%) 2.8% ( 0% - 6%) 0.000
FilteredTerm 61.22 (1.9%) 63.11
(2.5%) 3.1% ( -1% - 7%) 0.001
FilteredOr2Terms2StopWords 53.51 (2.5%) 55.30
(1.6%) 3.3% ( 0% - 7%) 0.000
FilteredOrHighMed 68.63 (1.8%) 70.99
(1.4%) 3.4% ( 0% - 6%) 0.000
DismaxOrHighHigh 40.56 (1.8%) 42.14
(2.7%) 3.9% ( 0% - 8%) 0.000
CombinedOrHighMed 41.70 (2.3%) 43.46
(1.9%) 4.2% ( 0% - 8%) 0.000
Or3Terms 88.16 (6.0%) 93.47
(9.5%) 6.0% ( -8% - 22%) 0.076
DismaxOrHighMed 71.65 (1.5%) 76.25
(2.3%) 6.4% ( 2% - 10%) 0.000
Or2Terms2StopWords 85.14 (4.8%) 91.00
(8.2%) 6.9% ( -5% - 20%) 0.016
OrHighMed 105.19 (1.9%) 115.17
(3.2%) 9.5% ( 4% - 14%) 0.000
OrHighRare 67.59 (10.4%) 76.68
(7.8%) 13.4% ( -4% - 35%) 0.001
DismaxTerm 325.96 (6.5%) 407.04
(5.6%) 24.9% ( 12% - 39%) 0.000
Term 297.83 (6.8%) 373.92
(7.9%) 25.5% ( 10% - 43%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
