Re: [PR] Modernize LineFileDocs. [lucene]

2024-01-16 Thread via GitHub
s1monw commented on PR #12929: URL: https://github.com/apache/lucene/pull/12929#issuecomment-1893520487 I was working on adding some new BWC tests for the parent field and it seems BWC index creation and testing is relying on some things that changed here. Just flagging this for now while I

Re: [PR] Modernize LineFileDocs. [lucene]

2023-12-19 Thread via GitHub
jpountz merged PR #12929: URL: https://github.com/apache/lucene/pull/12929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Modernize LineFileDocs. [lucene]

2023-12-19 Thread via GitHub
jpountz commented on PR #12929: URL: https://github.com/apache/lucene/pull/12929#issuecomment-1862488472 From a quick check, the luceneutil version has much more complexity around indexing facets, doc values, etc. It's not entirely obvious to me if sharing the code would help or hurt. --

Re: [PR] Modernize LineFileDocs. [lucene]

2023-12-14 Thread via GitHub
mikemccand commented on PR #12929: URL: https://github.com/apache/lucene/pull/12929#issuecomment-1855665643 > @mikemccand luceneutil is better at remaining up-to-date with Lucene than Lucene itself :) [mikemccand/luceneutil@76ff349](https://github.com/mikemccand/luceneutil/commit/76ff349499

Re: [PR] Modernize LineFileDocs. [lucene]

2023-12-13 Thread via GitHub
jpountz commented on PR #12929: URL: https://github.com/apache/lucene/pull/12929#issuecomment-1853880383 @mikemccand luceneutil is better at remaining up-to-date with Lucene than Lucene itself :) https://github.com/mikemccand/luceneutil/commit/76ff349499fe6226c9ea74c37dd2fa9db3a46272 http

[PR] Modernize LineFileDocs. [lucene]

2023-12-12 Thread via GitHub
jpountz opened a new pull request, #12929: URL: https://github.com/apache/lucene/pull/12929 This replaces `StringField`/`SortedDocValuesField` with `KeywordField` and `IntPoint`/`NumericDocValuesField` with `IntField`. -- This is an automated message from the Apache Git Service. To re