mikemccand commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2225379585
Thank you @slow-J and @stefanvodita!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
stefanvodita commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2221008091
I went ahead and merged since this PR had been pending for a few weeks.
Thank you @slow-J for your contribution and @mikemccand for reviewing!
--
This is an automated message from
stefanvodita merged PR #13489:
URL: https://github.com/apache/lucene/pull/13489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
github-actions[bot] commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2209661435
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
slow-J commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2180605011
Hi @mikemccand can we merge or are we waiting for more reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
slow-J commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2169232440
> > While I am already touching these, let me know if anyone has strong
opinions and I can also fix the `Statement lambda can be replaced with
expression lambda` or `Redundant array creat
slow-J commented on code in PR #13489:
URL: https://github.com/apache/lucene/pull/13489#discussion_r1640936281
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java:
##
@@ -694,7 +694,7 @@ private void checkResults(
"dim" +
mikemccand commented on code in PR #13489:
URL: https://github.com/apache/lucene/pull/13489#discussion_r1640748830
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java:
##
@@ -694,7 +694,7 @@ private void checkResults(
"dim
mikemccand commented on PR #13489:
URL: https://github.com/apache/lucene/pull/13489#issuecomment-2169122348
> While I am already touching these, let me know if anyone has strong
opinions and I can also fix the `Statement lambda can be replaced with
expression lambda` or `Redundant array cre
slow-J opened a new pull request, #13489:
URL: https://github.com/apache/lucene/pull/13489
Fixing some IDE "warnings", such as removing some dead code + fixing a link
+ adding use of try-with-resources.
Did not fix `'search(org.apache.lucene.search.Query,
org.apache.lucene.search.Col
10 matches
Mail list logo
