Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-30 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2509024818 This helped on nightly benchmarks as well, e.g. `AndHighHigh` and `AndStopWords` got a 10% speedup. https://benchmarks.mikemccandless.com/AndHighHigh.html https://benchmarks.mikemccandl

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz merged PR #14023: URL: https://github.com/apache/lucene/pull/14023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2507707084 Benchmarks results are still good: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-29 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2507695294 Thanks @ChrisHegarty for looking, I was about to ping you. :) I reflected more on this change. The bits about specializing our bulk scorers that compute top-k hits by score with `I

Re: [PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-27 Thread via GitHub
jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2504516781 This gives a good speedup when running a tasks file that has very diverse queries like we now do in nightly benchmarks: ``` TaskQPS baseline Std

[PR] Make inlining decisions a bit more predictable in our main queries. [lucene]

2024-11-27 Thread via GitHub
jpountz opened a new pull request, #14023: URL: https://github.com/apache/lucene/pull/14023 This implements a small contained hack to make sure that our compound scorers like `MaxScoreBulkScorer`, `ConjunctionBulkScorer`, `BlockMaxConjunctionBulkScorer`, `WANDScorer` and `ConjunctionDISI` o