jpountz commented on PR #14023: URL: https://github.com/apache/lucene/pull/14023#issuecomment-2507695294
Thanks @ChrisHegarty for looking, I was about to ping you. :) I reflected more on this change. The bits about specializing our bulk scorers that compute top-k hits by score with `ImpactsEnum` is not controversial I believe, so I'm keeping it (`MaxScoreBulkScorer`, `BlockMaxConjunctionBulkScorer`, `BlockMaxConjunctionScorer`, `WANDScorer`). However, the bit about specializing other types of queries for `PostingsEnum` is less obvious since the iterators could likely be a `BitSetIterator`, a doc-value iterator, or something else. (`ConjunctionBulkScorer`, `ConjunctionDISI`) so I reverted this part, we can look into these queries in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
