keikino commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2076765447
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieReader.java:
##
@@ -74,14 +77,39 @@ IndexInput floorData(TrieReader r) throws IOException {
gf2121 commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2076752951
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieReader.java:
##
@@ -74,14 +77,39 @@ IndexInput floorData(TrieReader r) throws IOException {
keikino commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2076665581
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieReader.java:
##
@@ -74,14 +77,39 @@ IndexInput floorData(TrieReader r) throws IOException {
gf2121 commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2075050725
##
lucene/core/src/test/org/apache/lucene/codecs/lucene103/blocktree/TestTrie.java:
##
@@ -71,6 +74,46 @@ public void testOneByteTerms() throws Exception {
}
}
gf2121 commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2074991144
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieBuilder.java:
##
@@ -63,7 +67,7 @@ private enum Status {
private static class Node {
gf2121 commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2074987659
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieReader.java:
##
@@ -74,14 +77,39 @@ IndexInput floorData(TrieReader r) throws IOException {
gf2121 commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2074972349
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieReader.java:
##
@@ -190,9 +218,19 @@ Node lookupChild(int targetLabel, Node parent, Node child)
mikemccand commented on code in PR #14494:
URL: https://github.com/apache/lucene/pull/14494#discussion_r2073325953
##
lucene/core/src/java/org/apache/lucene/codecs/lucene103/blocktree/TrieBuilder.java:
##
@@ -201,17 +208,53 @@ void save(DataOutput meta, IndexOutput index) throws
github-actions[bot] commented on PR #14494:
URL: https://github.com/apache/lucene/pull/14494#issuecomment-2848878110
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
mikemccand commented on PR #14494:
URL: https://github.com/apache/lucene/pull/14494#issuecomment-2816860016
Whoa, exciting! I will try to review soon! Thanks @gf2121.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
10 matches
Mail list logo