Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
shubhamvishu commented on PR #13001: URL: https://github.com/apache/lucene/pull/13001#issuecomment-1883422583 > In general this looks fine, although I think we should also work on remove some of those sleeps. For all others there should be an explanation, why the test needs sleeping.

Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
uschindler commented on PR #13001: URL: https://github.com/apache/lucene/pull/13001#issuecomment-1883368845 P.S.: You don't need to force-push, it is better to keep track what was changed in a PR. The PR will get squashed anyways. -- This is an automated message from the Apache Git Servic

Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
shubhamvishu commented on code in PR #13001: URL: https://github.com/apache/lucene/pull/13001#discussion_r1446269754 ## gradle/validation/forbidden-apis/defaults.all.txt: ## @@ -74,3 +74,8 @@ javax.sql.rowset.spi.SyncFactory @defaultMessage Math.fma is insanely slow (2500x) in

Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
shubhamvishu commented on code in PR #13001: URL: https://github.com/apache/lucene/pull/13001#discussion_r1446269754 ## gradle/validation/forbidden-apis/defaults.all.txt: ## @@ -74,3 +74,8 @@ javax.sql.rowset.spi.SyncFactory @defaultMessage Math.fma is insanely slow (2500x) in

Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
uschindler commented on code in PR #13001: URL: https://github.com/apache/lucene/pull/13001#discussion_r1446135710 ## gradle/validation/forbidden-apis/defaults.all.txt: ## @@ -74,3 +74,8 @@ javax.sql.rowset.spi.SyncFactory @defaultMessage Math.fma is insanely slow (2500x) in ma

Re: [PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
uschindler commented on code in PR #13001: URL: https://github.com/apache/lucene/pull/13001#discussion_r1446133887 ## gradle/validation/forbidden-apis/defaults.all.txt: ## @@ -74,3 +74,8 @@ javax.sql.rowset.spi.SyncFactory @defaultMessage Math.fma is insanely slow (2500x) in ma

[PR] Forebidden Thread.sleep API [lucene]

2024-01-09 Thread via GitHub
shubhamvishu opened a new pull request, #13001: URL: https://github.com/apache/lucene/pull/13001 ### Description This API mark `Thread.sleep` API as forebidden for futures uses in the codebase and suppresses the existing usages. Closes #12946 -- This is an automated