uschindler merged PR #12626:
URL: https://github.com/apache/lucene/pull/12626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816818775
Made the changes. Thanks @uschindler @MarcusSorealheis @msfroh 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
MarcusSorealheis commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816799469
@Shibi-bala It's here:
https://github.com/apache/lucene/blob/c228e4bb66ca73c8150d8eaebe2bb999bcc6c9b1/lucene/CHANGES.txt#L147
You need to include your user and the
uschindler commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816614768
You can't do it.
Please add a Changes entry unter the 9.9 section, commit it to branch and I
will merge and Backport your PR.
I am just away from my computer at moment, s
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1816600417
@uschindler hey, thanks for the approval! Read the contributing guidelines,
but not entirely sure how to get permissions to merge this PR.
--
This is an automated message from the A
MarcusSorealheis commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1813833061
Looks good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1813343695
@uschindler Ah I needed to re-sync my forked repo 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
uschindler commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1811511529
Have you merged in the latest main branch, so this PR is uptodate? This
could be an issue which already existed when the PR was created.
--
This is an automated message from the Apa
Shibi-bala commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1811494543
Kind of confused why this check is failing. This was never changed and I've
tried merging.
1```
. ERROR in
/home/runner/work/lucene/lucene/lucene/test-framework/src/java/org
Shibi-bala commented on code in PR #12626:
URL: https://github.com/apache/lucene/pull/12626#discussion_r1365943821
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception {
dir.close();
msfroh commented on code in PR #12626:
URL: https://github.com/apache/lucene/pull/12626#discussion_r1360880697
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception {
dir.close();
msfroh commented on code in PR #12626:
URL: https://github.com/apache/lucene/pull/12626#discussion_r1360878505
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception {
dir.close();
MarcusSorealheis commented on PR #12626:
URL: https://github.com/apache/lucene/pull/12626#issuecomment-1763688716
Hi @Shibi-bala and great to see you here. Let's sync up this week and maybe
we can help move this PR forward. It's a good catch, so thank you.
--
This is an automated message
Shibi-bala opened a new pull request, #12626:
URL: https://github.com/apache/lucene/pull/12626
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
14 matches
Mail list logo
