Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-17 Thread via GitHub
vigyasharma commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2062495992 Backported to `branch_9x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-10 Thread via GitHub
vigyasharma merged PR #13283: URL: https://github.com/apache/lucene/pull/13283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
benwtrent commented on code in PR #13283: URL: https://github.com/apache/lucene/pull/13283#discussion_r1558261300 ## lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java: ## @@ -786,9 +830,9 @@ public void testTimeout() throws IOException { assert

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
kaivalnp commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2045841382 Ah thanks! I fixed and unmuted [one](https://github.com/apache/lucene/blob/26fe2c4b9ca13e7930b818033a04094a5f44d574/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCa

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-09 Thread via GitHub
vigyasharma commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2045746855 Let us also [unmute](https://github.com/apache/lucene/pull/13273) the broken tests as part of this change? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-08 Thread via GitHub
kaivalnp commented on PR #13283: URL: https://github.com/apache/lucene/pull/13283#issuecomment-2043802370 Side note: the original command to reproduce from https://github.com/apache/lucene/pull/13202#issuecomment-2037932211: ``` gradlew :lucene:core:test --tests "org.apache.lucene

[PR] Fix failing BaseKnnVectorQueryTestCase#testTimeout [lucene]

2024-04-08 Thread via GitHub
kaivalnp opened a new pull request, #13283: URL: https://github.com/apache/lucene/pull/13283 ### Description Fixes #13272 The failure happens because of [this assumption](https://github.com/apache/lucene/blob/df0384c34fde8118513e7bc7b79dbde923070c8b/lucene/core/src/test/org/ap