kaivalnp opened a new pull request, #13283: URL: https://github.com/apache/lucene/pull/13283
### Description Fixes #13272 The failure happens because of [this assumption](https://github.com/apache/lucene/blob/df0384c34fde8118513e7bc7b79dbde923070c8b/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java#L788-L791) of the HNSW graph having just 1 level, but we get more than 1 for some seed values -- so the counting timeout of 1 node is exhausted while trying to find the best entry point for the last level, and we consequently get no results, failing [this assertion](https://github.com/apache/lucene/blob/df0384c34fde8118513e7bc7b79dbde923070c8b/lucene/core/src/test/org/apache/lucene/search/BaseKnnVectorQueryTestCase.java#L791) The assertion wants to check that when an approximate search is performed (some docs are fed to the collector), we return partial results even after a timeout -- and we can check this explicitly in a separate test for `TimeLimitingKnnCollectorManager` With that test in place, and since we cannot easily control the number of levels in the underlying graph, can we relax the test to check for "at most 1 result" instead of "exactly 1 result"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
