msokolov merged PR #13743:
URL: https://github.com/apache/lucene/pull/13743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
msokolov commented on PR #13743:
URL: https://github.com/apache/lucene/pull/13743#issuecomment-2351686402
> its tricky to find some sane epsilon in this case (which would only skip
running the test unnecessarily)
I agree, and this is fine, but my intuition is there will be some fiddl
shubhamvishu commented on code in PR #13743:
URL: https://github.com/apache/lucene/pull/13743#discussion_r1757244198
##
lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java:
##
@@ -255,4 +257,9 @@ private List
getTessellation(XYPolygon p) {
}
return
shubhamvishu commented on code in PR #13743:
URL: https://github.com/apache/lucene/pull/13743#discussion_r1757244198
##
lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java:
##
@@ -255,4 +257,9 @@ private List
getTessellation(XYPolygon p) {
}
return
stefanvodita commented on code in PR #13743:
URL: https://github.com/apache/lucene/pull/13743#discussion_r1757126653
##
lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java:
##
@@ -255,4 +257,9 @@ private List
getTessellation(XYPolygon p) {
}
return
shubhamvishu commented on PR #13743:
URL: https://github.com/apache/lucene/pull/13743#issuecomment-2346624909
Yes, usually we do that but in this case there is a catch. This test ONLY
fails when the generated points are non collinear(as expected) but the `area ==
0` ([checked in this
condi
msokolov commented on PR #13743:
URL: https://github.com/apache/lucene/pull/13743#issuecomment-2346349295
Should we have an epsilon here rather than exact comparison with 0? Usually
that's the way of things with floating point checks - we would check |a-b| <
epsilon
--
This is an automat
shubhamvishu opened a new pull request, #13743:
URL: https://github.com/apache/lucene/pull/13743
### Description
With the culprit seed (`C6E272EBEF02886F`) the generated polygon or triangle
have extremely close coordinates(`[(0.0,1.757358717152938E-241),
(-4.0378026254892873E-84, 0.0
