shubhamvishu commented on code in PR #13743:
URL: https://github.com/apache/lucene/pull/13743#discussion_r1757244198
##########
lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java:
##########
@@ -255,4 +257,9 @@ private List<ShapeField.DecodedTriangle>
getTessellation(XYPolygon p) {
}
return tess;
}
+
+ /** Compute signed area of rectangle */
+ private static double area(Polygon p) {
+ return (p.maxLon - p.minLon) * (p.maxLat - p.minLat);
Review Comment:
Nope, its possible that both the parts of multiplication are `> 0`(non zero)
but the result/area is 0 if the result goes beyond the double range(Eg:
(`1E-240 * 1E-78` is `0.0`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
