Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-29 Thread via GitHub
github-actions[bot] commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2840521041 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804210293 > What would be the right way to get the original input string then, please? Or do you just declare that `RegExp` does not support that? > It doesn't have a method to support thi

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
Tasssadar commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804173363 > Separately: the output of .toString() is just that, for humans, and not guaranteed to be reparsable. I can practically guarantee it is a bad idea to do this. What would be the

Re: [PR] Fix RegExp.toString generating invalid RE for CHAR and CHAR_RANGE [lucene]

2025-04-15 Thread via GitHub
rmuir commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804077216 I like the change. We can get fancy and extend it in the future, but the `toString()` today does not do its one job, the output is not readable. This fixes it to be more practical and not