Tasssadar commented on PR #14493: URL: https://github.com/apache/lucene/pull/14493#issuecomment-2804173363
> Separately: the output of .toString() is just that, for humans, and not guaranteed to be reparsable. I can practically guarantee it is a bad idea to do this. What would be the right way to get the original input string then, please? Or do you just declare that `RegExp` does not support that? Also, it's not just about readability - even as a human, if I see `regex.toString() == "\\s"`, before this fix, I don't know whether it is `s` character or `whitespace` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
