Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-13 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1840714602 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-12 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1838528845 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-07 Thread via GitHub
iverase commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1833247096 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points,

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-07 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1833153027 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-07 Thread via GitHub
iverase commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1832348844 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points,

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1826241555 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1826238079 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-28 Thread via GitHub
BrianWoolfolk commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1819467637 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues p

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-28 Thread via GitHub
BrianWoolfolk commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1819458522 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -20,9 +20,11 @@ import java.util.ArrayDeque; import java

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-23 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1812687585 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-10 Thread via GitHub
BrianWoolfolk commented on PR #13886: URL: https://github.com/apache/lucene/pull/13886#issuecomment-2406383720 There are some failing tests because of the unused methods and imports from the older logic, and I wanted to see if my implementation of the doc skipper is good before removing the

[PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-10-10 Thread via GitHub
BrianWoolfolk opened a new pull request, #13886: URL: https://github.com/apache/lucene/pull/13886 Fixes #13840 `IndexSortSortedNumericDocValuesRangeQuery` now implements a similar logic (using `DocValuesSkipper`) as `SortedNumericDocValuesRangeQuery`'s `getDocIdSetIteratorOrNullForP