BrianWoolfolk opened a new pull request, #13886: URL: https://github.com/apache/lucene/pull/13886
Fixes #13840 `IndexSortSortedNumericDocValuesRangeQuery` now implements a similar logic (using `DocValuesSkipper`) as `SortedNumericDocValuesRangeQuery`'s `getDocIdSetIteratorOrNullForPrimarySort` method. ### Description Since `IndexSortSortedNumericDocValuesRangeQuery` and `SortedNumericDocValuesRangeQuery` share similarities regarding _primarySort_, I updated the first one's logic to utilize the skipper advantages. I'd say this PR is not _fully_ completed, in the sense that the previous search logic is still there but never used (specifically the methods `nextDoc`, `findNextValue`, `lastDoc`, `matchNone`, `matchAll`, which I want to imagine got 'replaced' by the skipper altogether). The current changes still comply with the tests, but because of them being _optimization changes_ I couldn't really tell if the method has better performance or not, and so I wanted to hear your takes on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
