uschindler commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2423649656
Hi,
This was planned to be backwards incompatible. There is a migration guide
entry.
Lucene generally revises APIs between major versions in incompatible ways.
With Lucene
wardle commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2423217820
Hi all. I understand the change to a record class but this does create a
breaking change that would be avoided through the addition of deprecated
accessors matching the old class ie getQu
uschindler merged PR #13261:
URL: https://github.com/apache/lucene/pull/13261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2037428907
The failing test is a known issue (see mailing list). Just ignore that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Pulkitg64 commented on code in PR #13261:
URL: https://github.com/apache/lucene/pull/13261#discussion_r1551738126
##
lucene/core/src/java/org/apache/lucene/search/BooleanClause.java:
##
@@ -67,25 +67,12 @@ public String toString() {
};
}
- /** The query whose matching
Pulkitg64 commented on code in PR #13261:
URL: https://github.com/apache/lucene/pull/13261#discussion_r1551703918
##
lucene/core/src/java/org/apache/lucene/search/BooleanClause.java:
##
@@ -67,25 +67,12 @@ public String toString() {
};
}
- /** The query whose matching
uschindler commented on code in PR #13261:
URL: https://github.com/apache/lucene/pull/13261#discussion_r1551701906
##
lucene/core/src/java/org/apache/lucene/search/BooleanClause.java:
##
@@ -67,25 +67,12 @@ public String toString() {
};
}
- /** The query whose matchin
uschindler commented on code in PR #13261:
URL: https://github.com/apache/lucene/pull/13261#discussion_r1551695502
##
lucene/core/src/java/org/apache/lucene/search/BooleanClause.java:
##
@@ -67,25 +67,12 @@ public String toString() {
};
}
- /** The query whose matchin
uschindler commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2037230661
> That's a good idea @jpountz. I can add this change under this section:
https://github.com/apache/lucene/blob/main/lucene/MIGRATE.md#some-classes-converted-to-records-classes-github13
Pulkitg64 commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2037226302
That's a good idea @jpountz. I can add this change under this section:
https://github.com/apache/lucene/blob/main/lucene/MIGRATE.md#some-classes-converted-to-records-classes-github13207
jpountz commented on PR #13261:
URL: https://github.com/apache/lucene/pull/13261#issuecomment-2037159161
> Please add a note to lucene/MIGRATE.txt
By the way, I wonder how we should handle all the classes that we are
converting to records, should we have a single section in `lucene/MI
Pulkitg64 opened a new pull request, #13261:
URL: https://github.com/apache/lucene/pull/13261
### Description
Convert ```BooleanClause``` class to record class which addresses #13207
partially.
--
This is an automated message from the Apache Git Service.
To respond to the message,
12 matches
Mail list logo
