wardle commented on PR #13261: URL: https://github.com/apache/lucene/pull/13261#issuecomment-2423217820
Hi all. I understand the change to a record class but this does create a breaking change that would be avoided through the addition of deprecated accessors matching the old class ie getQuery and getOccur, which could be later removed in Lucene 11. Obviously other changes have been easier to manage in moving from Lucene 9->10 because methods have been flagged as deprecated in 9 and it has been straightforward to prepare for these changes. It is tricky because for users of Lucene with codebases that might run on either Java 11, or 21, one previously could have a codebase that would run using different Lucene versions, but this change means one has to choose the correct Lucene version AND keep two branches of their code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
