Re: [PR] BlockJoinBulkScorer could check for parent deletions (not children) [lucene]

2025-03-21 Thread via GitHub
jimczi closed pull request #14067: BlockJoinBulkScorer could check for parent deletions (not children) URL: https://github.com/apache/lucene/pull/14067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] BlockJoinBulkScorer could check for parent deletions (not children) [lucene]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #14067: URL: https://github.com/apache/lucene/pull/14067#issuecomment-2566030803 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] BlockJoinBulkScorer could check for parent deletions (not children) [lucene]

2024-12-16 Thread via GitHub
jpountz commented on PR #14067: URL: https://github.com/apache/lucene/pull/14067#issuecomment-2545527000 Indeed. We have a few such assertions already, e.g. to check that docs returned by the child query don't match the parent bitset. Adding a few more would be good if it can be done in a r

Re: [PR] BlockJoinBulkScorer could check for parent deletions (not children) [lucene]

2024-12-16 Thread via GitHub
ChrisHegarty commented on PR #14067: URL: https://github.com/apache/lucene/pull/14067#issuecomment-2545123613 > Block-joins require deletes to be consistent across parent and child documents. This seems a little fragile, and place where bugs could hide. I wonder if we should assert t