Re: [PR] Add prefetching support to stored fields. [lucene]

2024-06-03 Thread via GitHub
jpountz merged PR #13424: URL: https://github.com/apache/lucene/pull/13424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-29 Thread via GitHub
gf2121 commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1618348032 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long num

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-29 Thread via GitHub
jpountz commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1618325471 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long nu

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-28 Thread via GitHub
gf2121 commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1618303808 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long num

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-28 Thread via GitHub
rmuir commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1617177543 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long numB

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-27 Thread via GitHub
jpountz commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1616375903 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long nu

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-27 Thread via GitHub
rmuir commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1616256454 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long numB

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-27 Thread via GitHub
rmuir commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1616250356 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ## @@ -609,6 +622,23 @@ public void skipBytes(long numB

Re: [PR] Add prefetching support to stored fields. [lucene]

2024-05-27 Thread via GitHub
jpountz commented on PR #13424: URL: https://github.com/apache/lucene/pull/13424#issuecomment-2133420215 Like for previous changes, I wrote a synthetic benchmark to make sure that this new API actually helps. This benchmark simulates fetching 20 random stored documents in paralle

[PR] Add prefetching support to stored fields. [lucene]

2024-05-27 Thread via GitHub
jpountz opened a new pull request, #13424: URL: https://github.com/apache/lucene/pull/13424 This adds `StoredFields#prefetch(int)`, which mostly delegates to `IndexInput#prefetch`. Callers can take advantage of this API to parallelize I/O across multiple stored documents by first calling `S