rmuir commented on code in PR #13424: URL: https://github.com/apache/lucene/pull/13424#discussion_r1617177543
########## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java: ########## @@ -609,6 +622,23 @@ public void skipBytes(long numBytes) throws IOException { } } + @Override + public void prefetch(int docID) throws IOException { + final long blockID = indexReader.getBlockID(docID); + + for (long prefetchedBlockID : prefetchedBlockIDCache) { + if (prefetchedBlockID == blockID) { + return; + } + } Review Comment: Lets separate the concerns. This is fine for now, I'm just concerned that it stays small. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org