Re: [PR] Add leafReaders() Method to IndexReader and Unit Test [lucene]

2025-04-04 Thread via GitHub
benwtrent commented on PR #14370: URL: https://github.com/apache/lucene/pull/14370#issuecomment-2736659338 Eh, I am not sold that this change needs to occur if ever. While, "this is how its always been" isn't a good argument for some things, I think expanding the public, and then backwards

Re: [PR] Add leafReaders() Method to IndexReader and Unit Test [lucene]

2025-03-24 Thread via GitHub
jpountz commented on PR #14370: URL: https://github.com/apache/lucene/pull/14370#issuecomment-2748907675 Agreed with @benwtrent and @jainankitk. I'm closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add leafReaders() Method to IndexReader and Unit Test [lucene]

2025-03-24 Thread via GitHub
jpountz closed pull request #14370: Add leafReaders() Method to IndexReader and Unit Test URL: https://github.com/apache/lucene/pull/14370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Add leafReaders() Method to IndexReader and Unit Test [lucene]

2025-03-19 Thread via GitHub
jainankitk commented on PR #14370: URL: https://github.com/apache/lucene/pull/14370#issuecomment-273732 > Eh, I am not sold that this change needs to occur if ever. While, "this is how its always been" isn't a good argument for some things, I think expanding the public, and then backwar

[PR] Add leafReaders() Method to IndexReader and Unit Test [lucene]

2025-03-19 Thread via GitHub
DivyanshIITB opened a new pull request, #14370: URL: https://github.com/apache/lucene/pull/14370 This PR introduces leafReaders() in IndexReader for direct access to LeafReader instances, improving usability over leaves(). A corresponding unit test ensures correctness by validating retrieva