vsop-479 commented on PR #14814:
URL: https://github.com/apache/lucene/pull/14814#issuecomment-2998497268
Thanks for explaining @msokolov, closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vsop-479 closed pull request #14814: Add isEmpty in PriorityQueue.
URL: https://github.com/apache/lucene/pull/14814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
msokolov commented on PR #14814:
URL: https://github.com/apache/lucene/pull/14814#issuecomment-2997973738
I believe the reason Collection has isEmpty() is there may be a way to more
efficiently know if size > 0? But that doesn't apply here, and I don't think we
ought to be adding sugar meth
vsop-479 commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2157890563
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code true}
vsop-479 commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2157867142
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code true}
stefanvodita commented on code in PR #14814:
URL: https://github.com/apache/lucene/pull/14814#discussion_r2156665168
##
lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java:
##
@@ -342,4 +342,13 @@ public T next() {
}
};
}
+
+ /**
+ * Returns {@code t
github-actions[bot] commented on PR #14814:
URL: https://github.com/apache/lucene/pull/14814#issuecomment-2987489716
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one.
If the PR doesn't need a changelog entry, then add the skip-changelog label to
it and you will stop
vsop-479 opened a new pull request, #14814:
URL: https://github.com/apache/lucene/pull/14814
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
